Migration fixes for lti2_tp #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 5, 2016 17:45
on recent versions of rails, migrations fail if the class name differs from the file name
rradonic
force-pushed
the
master
branch
2 times, most recently
from
7ac4776
to
f28aa43
Compare
added 5 commits
April 13, 2016 11:11
the call to invoke_unsigned_service was failing without it
the hardcoded path was causing an error during logging because the directory doesn't exist. store the wirelog in the log/ directory of the current rails app instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues with the lti2_tp migration:
The migration's file name differed from its class name. Rails refuses to run the migration unless these two names match.
The migration's down method wasn't dropping one of the tables it created.
These two issues are now fixed. Let me know if you disagree with anything or if anything else in the project needs to change as a result of the above changes.
Cheers,
Ranko